Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Performance Improvements #436

Merged
merged 3 commits into from Jan 19, 2017
Merged

[BUGFIX] Performance Improvements #436

merged 3 commits into from Jan 19, 2017

Conversation

offirgolan
Copy link
Collaborator

@offirgolan offirgolan commented Jan 18, 2017

Resolves #381.

Changes proposed:

  • Use defineProperty instead of creating classes via Ember.Object.extend

Finds:

  • Initially when I ran the test case provided in Validations slow performance #381 by @jakesjews, I got a resulting time of ~550ms. With the added changes, I now see around a 150ms to 200ms decrease in time (sometimes more).
  • After a bunch of time debugging, it looks like using extend to create new classes take a lot longer than actually using defineProperty on init.

cc @stefanpenner @rwjblue have you guys noticed this sort of thing in the past? I mean... it makes sense but from past experience, defineProperty is a pretty heavy hitter in terms of performance.

@offirgolan offirgolan changed the title [WIP] Performance fixes [BUGFIX] Performance Improvements Jan 18, 2017
@offirgolan offirgolan merged commit 25a2bc2 into master Jan 19, 2017
@offirgolan offirgolan deleted the performance-testing branch January 19, 2017 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant