Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'confirmation' example. #574

Merged
merged 1 commit into from Mar 31, 2018

Conversation

Projects
None yet
2 participants
@AMS777
Copy link
Contributor

commented Mar 27, 2018

Changes proposed:

  • Fix minor copy-paste error on documentation.

Tasks:

  • Added test case(s)
  • Updated documentation
@offirgolan

This comment has been minimized.

Copy link
Owner

commented Mar 31, 2018

Thanks for the fix @AMS777!

@offirgolan offirgolan merged commit 24d0839 into offirgolan:master Mar 31, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AMS777

This comment has been minimized.

Copy link
Contributor Author

commented Mar 31, 2018

Thanks @offirgolan!

@offirgolan

This comment has been minimized.

Copy link
Owner

commented Apr 2, 2018

@AMS777 now that I look at it, the original example was correct. See the demo page validations:

email: {
      validators: [
        validator('presence', true),
        validator('format', {
          type: 'email'
        })
      ]
    },
    emailConfirmation: validator('confirmation', {
      on: 'email',
      message: 'Email addresses do not match'
    }),

offirgolan added a commit that referenced this pull request Apr 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.