Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'confirmation' example. #574

Merged
merged 1 commit into from
Mar 31, 2018
Merged

Conversation

AMS777
Copy link
Contributor

@AMS777 AMS777 commented Mar 27, 2018

Changes proposed:

  • Fix minor copy-paste error on documentation.

Tasks:

  • Added test case(s)
  • Updated documentation

@offirgolan
Copy link
Collaborator

Thanks for the fix @AMS777!

@offirgolan offirgolan merged commit 24d0839 into adopted-ember-addons:master Mar 31, 2018
@AMS777
Copy link
Contributor Author

AMS777 commented Mar 31, 2018

Thanks @offirgolan!

@offirgolan
Copy link
Collaborator

offirgolan commented Apr 2, 2018

@AMS777 now that I look at it, the original example was correct. See the demo page validations:

email: {
      validators: [
        validator('presence', true),
        validator('format', {
          type: 'email'
        })
      ]
    },
    emailConfirmation: validator('confirmation', {
      on: 'email',
      message: 'Email addresses do not match'
    }),

offirgolan added a commit that referenced this pull request Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants