Add present object to params and use sendEvent #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@poteto since I was passive aggressively asked not to commit to master... 馃槄
This PR has a couple of things:
present
param to the passed args so you can quickly gage if there have been changes from the defaults. This sort of goes into how or if we wanna manage some sort of state object. For example, keep an object on the controller such asqParams.sortDirection.hasChanged
orqParams.hasChanged
.sendEvent
so we can useEmber.on
I really like this because you can now tap into this 'event' from a mixin, extends, or even an initializer to do something send over metrics via google analytics.