Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for refreshModel #32

Closed
wants to merge 1 commit into from
Closed

Adds support for refreshModel #32

wants to merge 1 commit into from

Conversation

jasonmit
Copy link
Contributor

@jasonmit jasonmit commented Aug 8, 2017

Fixes #26

@offirgolan
Copy link
Owner

offirgolan commented Aug 8, 2017 •
edited
Loading

@jasonmit we don't plan to support refreshModel since all the data fetching logic should now be moved to the controller. We have an alternative refresh option that acts in the same away. Is there another use case that I'm missing here?

On that note, I do like the REFRESH_TIMER logic :)

@jasonmit
Copy link
Contributor Author

jasonmit commented Aug 8, 2017 •
edited
Loading

Yeah I figured that was the reason. Just thought it would be nice to have the queryParam definition in one place. The use case is simply the need for the model hooks to refire and with it the substates to be respected. I'll trim down the PR to cancel the scheduled work though.

@jasonmit jasonmit closed this Aug 16, 2017
@alexlafroscia alexlafroscia mentioned this pull request Dec 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasonmit @offirgolan