Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't run under Node 18, breaks Strapi example app Foodadvisor #19

Closed
sonicviz opened this issue Dec 15, 2022 · 2 comments · Fixed by #22
Closed

Doesn't run under Node 18, breaks Strapi example app Foodadvisor #19

sonicviz opened this issue Dec 15, 2022 · 2 comments · Fixed by #22
Assignees
@LuisRodriguezLD
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@sonicviz
Copy link

https://github.com/strapi/foodadvisor

Tried installing under Node 18.x
Even after updating strapi-calendar version from 0.0.8 to 0.0.9 it still fails

E:\Source Control\AI Apps\Back End\Strapi\foodadvisor\api>yarn && yarn seed && yarn develop
yarn install v1.21.1
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error @offset-dev/strapi-calendar@0.0.9: The engine "node" is incompatible with this module. Expected version ">=12.x.x <=16.x.x". Got "18.12.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation
@sonicviz sonicviz changed the title Doesn't run under Node 18 Doesn't run under Node 18, breaks Strapi example app Foodadvisor Dec 15, 2022
@LuisRodriguezLD LuisRodriguezLD added bug Something isn't working good first issue Good for newcomers labels Jan 4, 2023
@LuisRodriguezLD LuisRodriguezLD self-assigned this Jan 4, 2023
@LuisRodriguezLD LuisRodriguezLD mentioned this issue Jan 4, 2023
Merged
@LuisRodriguezLD
Copy link
Contributor

LuisRodriguezLD commented Jan 4, 2023 •
edited
Loading

Hey, sorry the delay..
I have #22 covering this

Would you mind giving it a go to see if it meets your use case?
You can update your package.json to

"@offset-dev/strapi-calendar": "github:offset-dev/strapi-calendar#bug/adjust-node-restrictions"

@LuisRodriguezLD LuisRodriguezLD linked a pull request Jan 5, 2023 that will close this issue
Adjust node restrictions #22
Merged
@LuisRodriguezLD
Copy link
Contributor

Fixed in #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuisRodriguezLD LuisRodriguezLD

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust node restrictions offset-dev/strapi-calendar
2 participants
@sonicviz @LuisRodriguezLD