Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Downloader #9

Closed
rgaudin opened this issue Oct 14, 2022 · 3 comments
Closed

Implement Downloader #9

rgaudin opened this issue Oct 14, 2022 · 3 comments
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@rgaudin
Copy link
Member

rgaudin commented Oct 14, 2022

Most of the image-creator's work consists of downloading files:

  • base-image
  • container images
  • content to be placed on the card

Need is basic for now: given a URL, write it to a specified location on disk, reporting progress.
It should also be somewhat resilient to network hiccups
@rgaudin rgaudin added the enhancement New feature or request label Oct 14, 2022
@rgaudin rgaudin added this to the 1.0.0 milestone Oct 14, 2022
@rgaudin rgaudin mentioned this issue Oct 14, 2022
Closed
@kelson42
Copy link

For the (HTTP) downloading, we need:

  • Reporting solution (time estimation, status, error details, etc..)
  • Parallelisation of the download

rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
6ee69b6 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted

TBC
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
7782160 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted

TBC
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
2ac2e96 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted

TBC
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
62e85ca 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted

TBC
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
e48cc07 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted

TBC
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
599ef34 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted

TBC
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
c7c2efa 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted

TBC
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
a06a500 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted

TBC
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
55ee5f0 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted

TBC
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
070bde0 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted

TBC
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
a067ab4 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted

TBC
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
efe49ad 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted

TBC
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
98999b9 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted

TBC
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
fa1de84 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted

TBC
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
a5bb08d 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted
@rgaudin rgaudin mentioned this issue Dec 2, 2022
Merged
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
74b8b70 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
1f477d2 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
84b9138 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted
rgaudin added a commit that referenced this issue Dec 2, 2022
@rgaudin
Initial working version
c794fff 
This is a working prototype that can be used to create working images from valid config files.

Fixes:
- Specify the card/project configuration format & workflow #4
- Implement Basic program structure #7
- Implement image file manipulation #10

Starts without completing:
- Implement Progress Reporting #8: text UI (cli) is done and usable. Machine-readable JSON file is not but can be implemented via the logger and StepMachine.
- Implement Downloader #9: a basic requests-based downloader is present. Needs more work to support transfer issues and being interupted
@rgaudin rgaudin mentioned this issue Jan 3, 2024
Closed
@kelson42
Copy link

@rgaudin Might we close this issue now that #31 has been merged?

@rgaudin
Copy link
Member Author

rgaudin commented Mar 20, 2024

Indeed ; I forgot to link it

@rgaudin rgaudin closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
image-creator Cardshop
Status: Done
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@rgaudin @kelson42