Configurable task role #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofiliz
requested changes
Apr 23, 2018
providers/aws/fargate/pod.go
Outdated
| @@ -33,6 +33,9 @@ const ( | |||
|
|
|||
| // Reason used for task state changes. | |||
| taskGenericReason = "Initiated by user" | |||
|
|
|||
| // Annotation to configure the task role | |||
There was a problem hiding this comment.
Please end comment lines with a '.'
providers/aws/fargate/pod.go
Outdated
| @@ -51,6 +54,7 @@ type Pod struct { | |||
| taskCPU int64 | |||
| taskMemory int64 | |||
| containers map[string]*container | |||
| taskRoleArn *string | |||
There was a problem hiding this comment.
Can you please move this to between taskArn and taskStatus? So that all ARNs are together. Also, any reason for the type to be *string? Let's just store it as string, like the others.
providers/aws/fargate/cluster.go
Outdated
| @@ -223,6 +223,7 @@ func (c *Cluster) loadPodState() error { | |||
| pod.taskArn = *task.TaskArn | |||
| pod.taskStatus = *task.LastStatus | |||
| pod.taskRefreshTime = time.Now() | |||
| pod.taskRoleArn = taskDef.TaskRoleArn | |||
There was a problem hiding this comment.
Please move this new line to between taskArn and taskStatus, to follow the same order they were declared in the struct. See my other comment.
providers/aws/fargate/pod.go
Outdated
| if val, ok := pod.Annotations[taskRoleAnnotation]; ok { | ||
| taskDef.TaskRoleArn = aws.String(val) | ||
| } | ||
| fgPod.taskRoleArn = taskDef.TaskRoleArn |
There was a problem hiding this comment.
Can we please move this inside the if block? fdPod.taskRoleArn is only set if there is an annotation (ok == true), so shouldn't it be also inside the if block? Simply fdPod.taskRoleArn = val
Configurable task role via `iam.amazonaws.com/role`, which is also used by kube2iam.
johanneswuerbach
force-pushed
the
af-task-role
branch
from
93b2458
to
9f91146
Compare
|
Thank you @ofiliz, feedback addressed. |
ofiliz
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configurable task role via
iam.amazonaws.com/role, which is also usedby kube2iam.