Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not handle case where iframe fails to load #18

Open
Hengjie opened this issue Aug 13, 2015 · 2 comments
Open

Does not handle case where iframe fails to load #18

Hengjie opened this issue Aug 13, 2015 · 2 comments

Comments

@Hengjie
Copy link

Hengjie commented Aug 13, 2015

TypeError: Cannot read property 'contentWindow' of undefined
    at buildMessage (xdLocalStorage.js:53)
    at window.xdLocalStorage.window.xdLocalStorage.getItem (xdLocalStorage.js:112)
    at ng-xdLocalStorage.js:29

If the iframe fails to load for whatever reason, it should be handled gracefully with a rejection of promise.

@loter
Copy link

loter commented Mar 24, 2017

any chance to get it fixed? :) still experiencing this issue when using dist/scripts/ng-xdLocalStorage.min.js

@ofirdagan
Copy link
Owner

@loter - you can continue on prull request #19 and I'll merge. Currently it has conflicts..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants