Added ofi_gettime interfaces to support CLOCK_REALTIME #10050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-xiong
reviewed
May 28, 2024
There was a problem hiding this comment.
Please reformat the commit message so that:
(1) The first line (title line) is not too long (<= 72);
(2) Remove the brackets from [src/common]:, or further shorten it to common: or core:.
Also the prototypes of the new functions need to be added to include/ofi.h.
| @@ -303,7 +303,23 @@ uint32_t ofi_generate_seed(void) | |||
|
|
|||
| return rand_seed; | |||
| } | |||
| uint64_t ofi_get_realtime_ns(void) | |||
| uint64_t ofi_get_realtime_ms(void) | ||
| { | ||
| return ofi_get_realtime_ns() / 1000000; | ||
| } |
nikhilnanal
force-pushed
the
clock_monotonic_realtime
branch
4 times, most recently
from
dfdfc3e
to
78a7a1b
Compare
nikhilnanal
changed the title
nikhilnanal
force-pushed
the
clock_monotonic_realtime
branch
5 times, most recently
from
123e5ca
to
854a469
Compare
|
We don't need the brackets ( |
|
|
nikhilnanal
force-pushed
the
clock_monotonic_realtime
branch
from
854a469
to
585547f
Compare
Added new interfaces to support pthread_cond_timedwait which use CLOCK_REALTIME.In general CLOCK_MONOTONIC is preferred and in use by several providers, therefore new interfaces are added to support the special case of pthread apis. [prov/sockets]: changes made to use ofi_get_realtime instead of ofi_get_time before ofi_wait_cond. Signed-off-by: Nikhil Nanal <nikhil.nanal@intel.com>
nikhilnanal
force-pushed
the
clock_monotonic_realtime
branch
from
585547f
to
192eaed
Compare
j-xiong
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[src/common]: added ofi_get_realtime intefaces to support pthread_cond_timedwait which use CLOCK_REALTIME.In general CLOCK_MONOTONIC is preferred and in use by several providers, therefore new interfaces are added to support the special case of pthread apis.(ref #9614 )
[prov/sockets]: changes made to use ofi_get_realtime instead of ofi_get_time before ofi_wait_cond.
Signed-of-by: Nikhil Nanal nikhil.nanal@intel.com