prov/efa: do not do copy for inline send #10067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenduwan
reviewed
Jun 10, 2024
prov/efa/src/rdm/efa_rdm_pke_utils.c
Outdated
| * and the pkt size (hdr + data) is within inline buf size. | ||
| */ | ||
| } else if (!efa_mr_is_hmem(iov_mr) && | ||
| payload_offset + data_size <= efa_rdm_ep_domain(pke->ep)->device->efa_attr.inline_buf_size){ |
There was a problem hiding this comment.
nit missing space between ) and {
wenduwan
approved these changes
Jun 10, 2024
Efa can directly access memory if the buffer is host memory and the pkt size (hdr + data) is within inline buf size. Libfabric doesn't need to memcpy in this case. Signed-off-by: Shi Jin <sjina@amazon.com>
shijin-aws
force-pushed
the
no_copy_inline
branch
from
fbbb55d
to
142c871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Efa can directly access memory if the buffer is host memory and the pkt size (hdr + data) is within inline buf size. Libfabric doesn't need to memcpy in this case.