[v1.21.x] Backport pr10063 #10069
Merged
[v1.21.x] Backport pr10063 #10069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client-server tests currently read client output from pipe, which can be unavailable in corner cases, e.g. client timeout. This change directs the client process stdout/stderr to a file which is closed and saved upon completion. Signed-off-by: Wenduo Wang <wenduwan@amazon.com> (cherry picked from commit ff87df2)
…r tests Client-server tests launch tests over SSH which can introduce delays in addition to the specified timeout. This change adds more time before timing out Signed-off-by: Wenduo Wang <wenduwan@amazon.com> (cherry picked from commit 7b36891)
shijin-aws
approved these changes
Jun 10, 2024
|
@shijin-aws Good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #10063