fabric: Add fi_trywait call to support use of native wait objects #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new call that applications must use when waiting on the
native wait object associated with an EQ or CQ. The expected
behavior is for apps to do something like this:
while (1) {
if (fi_trywait(cq, ...) == 0)
poll(cq_fd, ...);
do {
ret = fi_cq_read(cq, ...);
} while (ret > 0);
}
The trywait call is responsible for performing any steps needed
to safely block on the underlying fd using standard OS calls.
Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Proper use of native wait objects will require the use of the new fi_trywait call. Disable all providers from returning the wait object until they support fi_trywait. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Add fi_trywait inline to fi_eq.h header file. Add prototype to fabric_ops structure. Provide an ENOSYS implementation. Update providers to reference ENOSYS implementation. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Add implementation for fi_trywait to the UDP provider. This updates the utility framework. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Re-enable FI_GETWAIT support and add fi_trywait implementation. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
|
👍 |
shefty
added a commit
that referenced
this pull request
Feb 25, 2016
fabric: Add fi_trywait call to support use of native wait objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series defines fi_trywait, disables providers from supporting fi_control FI_GETWAIT, and re-enables that support for the sockets and udp providers, along with fi_trywait implementation.
Other providers will need to re-enable fi_control FI_GETWAIT after implementing fi_trywait.
A separate PR will be made to fabtests. Until that request has been merged, fabtests related to testing native wait objects may fail.