Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/python: Convert python 2 scripts to version 3 #4883

Merged
merged 1 commit into from Mar 7, 2019

Conversation

shefty
Copy link
Member

@shefty shefty commented Mar 4, 2019

Upstream no longer supports python 2. Starting in RHEL 8
all python scripts must be python 3.

Signed-off-by: Sean Hefty sean.hefty@intel.com

Upstream no longer supports python 2.  Starting in RHEL 8
all python scripts must be python 3.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
@shefty
Copy link
Member Author

shefty commented Mar 4, 2019

updates were made by running 2to3 script because the patch author doesn't know python even a little

@shefty shefty requested a review from pmmccorm March 4, 2019 22:38
@pmmccorm
Copy link

pmmccorm commented Mar 7, 2019

Changes look fine. I didn't test them though, and if no one is actually using these scripts it should probably just be removed.

The yaml one was intended to verify the tools are producing proper yaml output.

@shefty shefty merged commit 328f32e into ofiwg:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants