-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new FI_ORDER bits for RMA and atomics #5019
Conversation
The current FI_ORDER bits combine RMA and atomic ordering together under a single set of bits. However, it's possible for both apps and providers to have these unordered wrt each other. Introduce a new set of bits that allow ordering RMA with other RMA operations, and atomic with other atomics, but keep RMA and atomics separate. This does not change the existing bits, but allows for fine grain control over ordering. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
The existing RAR, RAW, WAR, and WAW ordering bits automatically imply that the equivalent RMA and ATOMIC ordering. Enable those bits in the provider and core. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
@j-xiong @a-ilango @aingerson @mblockso @vkrishna -- These changes touch most of the providers. @hppritcha - This doesn't change the gni provider. I only see SAS support listed in that provider. But maybe the new bits might apply, where the old ones didn't fit? |
@pkcoff - adding Paul for BGQ updates |
BGQ code looks ok to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verbs, rxm changes look okay.
The windows build is having issues connecting to github. The tests that do connect, work. This is from the Intel CI:
It's unrelated, but I don't know what happened here. @aingerson |
psm and psm2 changes look fine. |
tcp changes looks good |
Shm change looks good. |
The new bits allow for ordering within RMA operations or atomic operations, without requiring ordering between RMA and atomics, as the current bits do.