Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prov/efa: Allow apps to reset RNR retry counter #7054

Merged
merged 1 commit into from Sep 16, 2021

Conversation

zhngaj
Copy link
Contributor

@zhngaj zhngaj commented Sep 13, 2021

prov/efa: Allow apps to reset RNR retry counter

This needs rebase after #7065 is merged.

Update: #7065 merged. This PR has been rebased.

@zhngaj zhngaj requested a review from a team September 13, 2021 15:12
@shefty
Copy link
Member

shefty commented Sep 13, 2021

Please separate changes to the main external API into their own PR, so that they don't get lost as part of a efa specific change.

include/rdma/fi_endpoint.h Outdated Show resolved Hide resolved
man/fi_efa.7.md Outdated Show resolved Hide resolved
prov/efa/src/rxr/rxr_ep.c Outdated Show resolved Hide resolved
This patch adds a mechanism to allow apps to reset
RNR retry counter before EP enablement via fi_setopt

Signed-off-by: Jie Zhang <zhngaj@amazon.com>
@zhngaj
Copy link
Contributor Author

zhngaj commented Sep 16, 2021

@shefty May I get failure in continuous-integration/jenkins/pr-head if it's a real issue?

@shefty
Copy link
Member

shefty commented Sep 16, 2021

It looks like it was a hang running MPI on the psm2 provider.

@zhngaj
Copy link
Contributor Author

zhngaj commented Sep 16, 2021

Then it's not related to the change in this PR. Thanks.

@zhngaj zhngaj requested a review from a team September 16, 2021 23:13
@wzamazon wzamazon merged commit a550f60 into ofiwg:main Sep 16, 2021
@zhngaj zhngaj deleted the main-rnr-reset branch September 24, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants