Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/intel/jenkins Cancel Stale Builds #7501

Merged
merged 1 commit into from Mar 5, 2022
Merged

Conversation

zachdworkin
Copy link
Contributor

Abort old builds if a new build gets added to the same job's queue
This will remove the need to abort old builds by hand
It will free up resources more quickly when open PRs have multiple changes pushed in quick succession to only test the latest changes

Signed-off-by: Zach Dworkin zachary.dworkin@intel.com

@zachdworkin
Copy link
Contributor Author

Tagging @nikhilnanal who helped figure this out.

@shefty
Copy link
Member

shefty commented Mar 3, 2022

Does the canceled build report an error back to github, or will github still show a pending status?

@zachdworkin
Copy link
Contributor Author

@shefty I am pretty sure that is because I had to abort replay the first build to reflect the jenkinsfile changes.
I also had to rebuild because verbs rxd/rxm failed for some reason so I am rerunning it.

It "should" reflect a success when the current build is done, assuming it has no failures.

abort old builds if a new build gets added to the queue

Signed-off-by: Zach Dworkin <zachary.dworkin@intel.com>
@zachdworkin
Copy link
Contributor Author

@shefty @aingerson
If you look at the jenkins job for this one I aborted #4 and replayed it with the updates to the jenkinsfile. I then started #6 as a replay of #5 shortly after #5 started. This shows that #5 was successfully aborted by #6 and #6 was able to continue running.

It will reflect a failure until the current running job completes with a pass. This is because of having to abort and replay #4 which github thinks is the check to look until #6 finishes.

We can remove the do not merge flag as well.
I need to give credit to Greg Junker for helping find this solution.

@shefty shefty merged commit 6044916 into ofiwg:main Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants