prov/efa: fix the gdrcopy_handle procedure #8902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenduwan
approved these changes
May 8, 2023
|
This PR needs some major change after discussing with the team. We need to remove the condition of FI_VERSION check for the hmem_data and gdrcopy handle flags within efa_mr.c, use 1.19 API version when calling shm's get_info. All of the changes mentioned above should be based on PR #8905 that update libfabric version to 1.19. |
The hmem_data field in ofi_mr will be ignored for api version < 1.19. In order to make shm use the gdrcopy handle stored in the hmem_data field, we need to call shm's fi_getinfo with 1.19 version. Signed-off-by: Shi Jin <sjina@amazon.com>
Efa is using the hmem_data internally to pass gdrcopy handle to shm, so it should not care what api version the application was using. Since this code is already part of libfabric 1.19, there is no need to add a version check. Signed-off-by: Shi Jin <sjina@amazon.com>
wenduwan
approved these changes
May 9, 2023
shijin-aws
changed the title
|
nit PR description should be updated. |
Thx, updated. |
wzamazon
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 commits to fix the procedure that efa pass gdrcopy handle to shm.