Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a "lerp" and "once" prop to Favicon #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NathanKoehler
Copy link

Added a lerp and once option to favicon, lerp will cause the animation to play in reverse on completion and once, when animated is false and once is true, will cause the animation to play once. Once and lerp also work together in that when once and lerp are both true, the favicon will play the reverse animation to return to the original state. Otherwise it will simply return to the initial position.

Added a lerp and once option to favicon, lerp will cause the animation to play in reverse on completion and once, when animated is false and once is true, will cause the animation to play once. Once and lerp also work together in that when once and lerp are both true, the favicon will play the reverse animation to return to the original state. Otherwise it will simply return to the initial position.
@oflisback
Copy link
Owner

Hi @NathanKoehler thanks for taking the time to do this, it looks useful.

Please use prettier to format the code in the PR and if you are up to it it would be nice if you also demonstrated usage in the example app (see the app under example/).

I'm about to update the tool-chain for this repo but this PR probably go in first. :)

@oflisback
Copy link
Owner

Hi @NathanKoehler, the big changes I mentioned have been merged, I'm sorry that it made the merge of this PR harder. If you'd like to give it another go please go ahead. If you do, then consider to install the prettier extension in vs code (or similar if you use another editor) for a cleaner patch. If you like I can make the additions to the example app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants