Refactor with thorough criteria #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 20, 2020 17:05
As discussed, this refactor should satisfy all the criteria of what the package should be doing.
To tell the usecase to be more clearer and I fix some typo in it.
Because calling a network image is not a reliable solution. So instead of using Image.network, I switch to Image.asset for displaying the Google Play Logo.
haritsfahreza
suggested changes
Mar 21, 2020
To make the user trying this package with ease. Also having an example can add 10 points on pub.dev score.
This reverts commit 6c36438.
milhomem
reviewed
Mar 22, 2020
milhomem
reviewed
Mar 22, 2020
milhomem
reviewed
Mar 22, 2020
milhomem
reviewed
Mar 22, 2020
milhomem
reviewed
Mar 22, 2020
milhomem
reviewed
Mar 22, 2020
|
LGTM |
haritsfahreza
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, this refactor should satisfy all the criteria of
what the package should be doing.