feat(join): Support delimeter as joiner

oftherivier · Apr 30, 2020 · 1d441be · 1d441be
1 parent 4d80335
commit 1d441be
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/join.js b/join.js
@@ -6,13 +6,14 @@ function join(a, b, c) {
     : joinMain(a, b, c)
 }
 
-function joinMain(id, joinerFn, makerFns) {
-  return joinerFn(tuple(id, makerFns))
+function joinMain(id, joiner, makerFns) {
+  var result = tuple(id, makerFns)
+  return typeof joiner === 'function' ? joiner(result) : result.join(joiner)
 }
 
-function joinCurried(joinerFn, makerFns) {
+function joinCurried(joiner, makerFns) {
   return function joinFn(id) {
-    return joinMain(id, joinerFn, makerFns)
+    return joinMain(id, joiner, makerFns)
   }
 }
 

diff --git a/tests/fictional.test.js b/tests/fictional.test.js
@@ -11,7 +11,7 @@ const curriedMakerDefs = [
   ],
   [
     join,
-    vals => vals.join(' '),
+    ' ',
     [oneOf(['Privet', 'Parkway', 'Cherry']), oneOf(['Drive', 'Street', 'Road'])]
   ]
 ]

diff --git a/tests/join.test.js b/tests/join.test.js
@@ -0,0 +1,8 @@
+const tap = require('tap')
+const { join } = require('..')
+
+tap.test('function as joiner', t => {
+  const result = join(23, vals => vals.join(' '), [() => 'a', () => 'b'])
+  t.equals(result, 'a b')
+  t.end()
+})