Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single-platform case unnecessary #17

Closed
kylemcdonald opened this issue Aug 23, 2015 · 3 comments
Closed

single-platform case unnecessary #17

kylemcdonald opened this issue Aug 23, 2015 · 3 comments

Comments

@kylemcdonald
Copy link
Contributor

i think when we are generating for a single platform (the one that this PG was packaged with for download) then the "platform" field might be unnecessary.

right now, for me it shows "Unknown" but maybe that has something to do with it not being initialized by default anywhere.

(i'm going to post a couple other things i noticed rather than compiling it in one issue/thread)

@ofZach
Copy link
Owner

ofZach commented Aug 23, 2015

I think showing it is useful for debugging / disambiguating. we showed this on the original simple PG and i think it's useful (at least for me, I find it helpful to know that I am using the ios PG vs the osx one).

it says undefined because the settings.json file is not up to date, I need to check in some changes. I also think the "display" names of the platforms are a little thin, vs should be visual studio, etc. I am working on that now.

@Daandelange
Copy link
Collaborator

You can change your default platform in settings.json
There's no auto-detect as this has to be packaged with the release files... but I'm still wondering how to make this work those who download the github repos.

Node-js has a platform detection feature; we might be able to use that ?
So it would be:
If there's a settings.json it uses the default platform from there, otherwise (for github repos) it auto-detects.

@ofZach
Copy link
Owner

ofZach commented Aug 24, 2015

i think this won't work for IOS. We should just give instructions and put in OSX for now since we are testing it on OSX. This was also a setting the settings.xml of the last PG so it's pretty similar to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants