Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts not working when using component in Studio with language other than English #5

Open
e-gallis opened this issue Feb 22, 2022 · 8 comments

Comments

@e-gallis
Copy link

Hi @TBag,
I just opened your MSAPP file in a Power Apps Studio that is in French, and here's the result :
BugCharts
This is due to the fact that decimal number have a comma "," in French instead of a point "." in English.
Meaning that the components works only in languages where the point "." is the decimal character.
To workaround this issue, all decimal number inside your components SVGs should be formatted using:
Text(... , "#.0", "en-US")
This will ensure that the component will always use the point "." as the decimal character, thus making the component to work for all languages.
I understand that's a lot of work so if you need any help, I'd be happy to assist... 😉

@TBag
Copy link
Collaborator

TBag commented Feb 22, 2022

Hello! Thanks for reporting this issue. Please feel free to make a PR for these changes and we can get it merged in.

@alexsolex
Copy link

I d'ont know if this issue is fixed yet but I got the same style of graph as @e-gallis
I think it is due to float numbers concatenated in svg. Numbers in svg uses dot as float number separator, whereas in french language, power apps uses semi column in float numbers. English people are not concerned because SVG and powerapps uses the dot for float numbers.

@e-gallis
Copy link
Author

Hi @alexsolex,
I finished (just 5 minutes ago 😅) updating the code for all charts to fix this issue. @TBag is not even aware of it (yet). I'll send him an email probably tomorrow and see with him how to push this update... 😉
So the "internationalized" version of the component should be available in the coming days... 😊

@alexsolex
Copy link

Good to know @e-gallis :) I was doing the same on my side + replacing some pieces of code for other ones like EncodeUrl(...) rather than Substitute(Substitute(Substitute(.... ;)

@e-gallis
Copy link
Author

@alexsolex can you contact me on LinkedIn (/in/egallis) so we can put this all together before we submit it to Todd? 😉

@heyjoj
Copy link

heyjoj commented Jul 28, 2023

Hi @e-gallis or @alexsolex,
i'm just struggling with the same language issue. Meanwhile there is no updated code available on github. I tried to fix it myself but i'm not sure how to place the "Text(... , "#.0", "en-US")". So i wonder if one of you should give me a whole example line or maybe send me the updated code by pm? 😉

@e-gallis
Copy link
Author

Hi @heyjoj,
I've fixed the issue. I'm just struggling to find some time to push the fix to Github. Seeing your message might just encourage me to do so... 😉

@heyjoj
Copy link

heyjoj commented Jul 31, 2023

Hi, that would be great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants