Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gen): minor metrics improvements #1210

Merged
merged 4 commits into from
Apr 4, 2024
Merged

feat(gen): minor metrics improvements #1210

merged 4 commits into from
Apr 4, 2024

Conversation

johnrutherford
Copy link
Contributor

@johnrutherford johnrutherford commented Apr 3, 2024 •
edited

Some minor metrics improvements:

  • Fixed comments with incorrect unit for duration metrics
  • Added functions to create metric instruments with description and unit
  • Updated template to use new functions for creating instruments
  • Updated template to specify instrumentation version when creating metric.Meter

@ernado ernado merged commit 26cf206 into ogen-go:main Apr 4, 2024
14 checks passed
@johnrutherford johnrutherford deleted the metrics-improvements branch April 4, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernado ernado ernado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnrutherford @ernado