Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gen): return ErrNotImplemented, if nameGen unable to generate name #190

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

tdakkota
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #190 (9340c09) into main (f917bb9) will decrease coverage by 1.30%.
The diff coverage is 37.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   68.01%   66.71%   -1.31%     
==========================================
  Files          99      100       +1     
  Lines        6275     6417     +142     
==========================================
+ Hits         4268     4281      +13     
- Misses       1759     1860     +101     
- Partials      248      276      +28     
Impacted Files Coverage Δ
gen/gen_request_body.go 41.46% <0.00%> (-10.06%) ⬇️
gen/generator.go 51.51% <0.00%> (-7.22%) ⬇️
gen/templates.go 89.92% <ø> (ø)
gen/fix.go 50.26% <27.02%> (-6.18%) ⬇️
gen/gen_parameters.go 52.45% <30.00%> (-4.56%) ⬇️
gen/generics.go 48.35% <31.25%> (-4.82%) ⬇️
gen/schema_gen_primitive.go 87.50% <35.71%> (-9.10%) ⬇️
gen/gen_contents.go 83.01% <40.00%> (-5.22%) ⬇️
gen/gen_responses.go 66.34% <41.93%> (-6.10%) ⬇️
gen/walk.go 52.63% <43.75%> (-47.37%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f917bb9...9340c09. Read the comment docs.

@tdakkota tdakkota marked this pull request as draft February 15, 2022 11:43
@tdakkota tdakkota changed the title fix(gen): fallback to pascalSpecial, if pascal generates empty name refactor(gen): return ErrNotImplemented, if nameGen unable to generate name Feb 15, 2022
@tdakkota tdakkota marked this pull request as ready for review February 15, 2022 13:13
@tdakkota tdakkota merged commit a98130b into ogen-go:main Feb 15, 2022
@tdakkota tdakkota deleted the fix/name-generation branch February 15, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant