New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with a non-zero status on error #146

Merged
merged 1 commit into from Apr 2, 2017

Conversation

2 participants
@spk
Contributor

spk commented Feb 26, 2017

With ls from Debian coreutils 8.26-2

ls /bad/path
echo $? # => 2

Reproduced same behaviour with exa

Fix #135
Compilation depend on #145

@ogham ogham self-assigned this Mar 29, 2017

@ogham ogham added this to the v0.5.0 milestone Mar 29, 2017

Exit with a non-zero status on error
With `ls` from Debian coreutils 8.26-2

```
ls /bad/path
echo $? # => 2
```

Reproduced same behaviour with exa

Fix #135

@ogham ogham merged commit f1be6b8 into ogham:master Apr 2, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@ogham

This comment has been minimized.

Show comment
Hide comment
@ogham

ogham Apr 2, 2017

Owner

Thanks! I can’t believe I missed this out.

Owner

ogham commented Apr 2, 2017

Thanks! I can’t believe I missed this out.

@spk

This comment has been minimized.

Show comment
Hide comment
@spk

spk Apr 2, 2017

Contributor

Thanks to you for creating this project and maintaining it !

Contributor

spk commented Apr 2, 2017

Thanks to you for creating this project and maintaining it !

@spk spk deleted the spk:fix-exit-status branch Apr 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment