Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to compile on rustc 1.8.0 (db2939409 2016-04-11) #24

Closed
eFrane opened this issue Nov 15, 2016 · 5 comments · Fixed by #25
Closed

Fails to compile on rustc 1.8.0 (db2939409 2016-04-11) #24

eFrane opened this issue Nov 15, 2016 · 5 comments · Fixed by #25
Assignees

Comments

@eFrane
Copy link

eFrane commented Nov 15, 2016

ansi-term fails to build on Debian Stretch testing with above said rustc version.

The error output is:

.cargo/registry/src/github.com-88ac128001ac3a9a/ansi_term-0.9.0/src/lib.rs:189:5: 189:23 error: user-defined types or type parameters cannot shadow the primitive types [E0317]
.cargo/registry/src/github.com-88ac128001ac3a9a/ansi_term-0.9.0/src/lib.rs:189     type str : ?Sized;
                                                                                          ^~~~~~~~~~~~~~~~~~
.cargo/registry/src/github.com-88ac128001ac3a9a/ansi_term-0.9.0/src/lib.rs:189:5: 189:23 help: run `rustc --explain E0317` to see a detailed explanation
@ogham ogham self-assigned this Nov 17, 2016
@ogham
Copy link
Owner

ogham commented Nov 17, 2016

Eeeep this is bad, will fix

@pdietl
Copy link

pdietl commented Dec 15, 2016

Any luck on this?

gtabares pushed a commit to gtabares/rust-ansi-term that referenced this issue Dec 18, 2016
@gtabares
Copy link

I have created a PR. It seems to fix the issue for me.

@eFrane
Copy link
Author

eFrane commented Jan 9, 2017

Update: With rust 1.14, the issue is gone.

@ogham ogham closed this as completed in #25 Jun 4, 2017
ogham added a commit that referenced this issue Jun 4, 2017
@ogham
Copy link
Owner

ogham commented Jun 4, 2017

I’m glad the original issue is gone, and I’ve merged that PR anyway, but I’m sorry that I never got back to doing this at the time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants