Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Temporary fix for numba update issue #51

Merged
merged 1 commit into from
Dec 1, 2018

Conversation

NicolasHug
Copy link
Collaborator

This is a temporary fix for #50 until numba/numba#3554 is fixed.

@codecov
Copy link

codecov bot commented Nov 30, 2018

Codecov Report

Merging #51 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   94.16%   94.17%   +0.01%     
==========================================
  Files           8        8              
  Lines         788      790       +2     
==========================================
+ Hits          742      744       +2     
  Misses         46       46
Impacted Files Coverage Δ
pygbm/splitting.py 98.95% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef25bfc...cc0d488. Read the comment docs.

Copy link
Owner

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for reporting upstream.

@ogrisel ogrisel merged commit 76445b1 into ogrisel:master Dec 1, 2018
@NicolasHug NicolasHug deleted the fix_numba_update branch December 9, 2018 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants