Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#64] 선생님 삭제(탈퇴) repository 테스트 및 구현 #68

Merged
merged 5 commits into from
Aug 6, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.ohdab.member.repository;

import static com.ohdab.member.domain.MemberStatus.INACTIVE;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.groups.Tuple.tuple;

Expand Down Expand Up @@ -93,6 +94,24 @@ public class MemberRepositoryTest {
member.getStatus());
}

@Test
@DisplayName("선생님 삭제(탈퇴) 성공 테스트")
void 선생님_삭제_및_탈퇴_성공() {
// given
Authority teacher = new Authority("TEACHER");
Member member = createMember("선생님", "tjstodsla", teacher);

// when
memberRepository.save(member);
member.withdrawal();
Member result = memberRepository.findById(member.getId()).get();

// then
assertThat(result)
.extracting(Member::getId, Member::getStatus)
.containsExactly(member.getId(), INACTIVE);
Comment on lines +104 to +112
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// when
memberRepository.save(member);
member.withdrawal();
Member result = memberRepository.findById(member.getId()).get();
// then
assertThat(result)
.extracting(Member::getId, Member::getStatus)
.containsExactly(member.getId(), INACTIVE);
// when
memberRepository.save(member);
member.withdrawal(); // -> 이 member가 save하고 반환받은 member가 아닌데 어떻게 성공한거야?
Member result = memberRepository.findById(member.getId()).get();
// then
assertThat(result)
.extracting(Member::getId, Member::getStatus)
.containsExactly(member.getId(), INACTIVE);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

걍 되던데? ㅋㅋㅋㅋ 잘 모르겠는데, 영속성 컨텍스트 관리 영역이라서 되는거 아니야?

}

private Member createMember(String name, String password, Authority role) {
List<Authority> authorities = new ArrayList<>();
authorities.add(role);
Expand Down
Loading