Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omf new tries to set newly created themes which does not make sense #529

Closed
sagebind opened this issue Jul 13, 2017 · 0 comments
Closed
Assignees
Labels
priority: normal Normal priority
Milestone

Comments

@sagebind
Copy link
Member

Creating a new theme using omf new theme <name> tries to set the newly created theme as the active theme before exiting, which is unexpected behavior and also always fails.

Since it fails, it leads omf.theme.set to print a misleading message asking the user to run omf install <name>, which makes sense in every context where omf theme is used except for this instance.

  1. Stop trying to set newly scaffolded themes as the active one.
  2. Move messages such as the one described above into omf.cli.theme instead of in omf.theme.set.
@sagebind sagebind added this to the v6 milestone Jul 13, 2017
@sagebind sagebind self-assigned this Jul 13, 2017
sagebind added a commit that referenced this issue Jul 13, 2017
@sagebind sagebind modified the milestones: v6, v7 Oct 5, 2017
rwappler pushed a commit to rwappler/oh-my-fish that referenced this issue Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Normal priority
Projects
None yet
Development

No branches or pull requests

1 participant