Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init: remove dupe in fish_function_path #247

Closed
wants to merge 1 commit into from
Closed

init: remove dupe in fish_function_path #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion init.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ set -l user_function_path $fish_function_path[1]
set fish_function_path[1] $OMF_PATH/lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me cringe every time I see it. 😖
Wouldn't it be more uniform and make more sense to:

  1. push the first entry to the end instead of erasing it and putting it back later?
  2. autoload both lib and lib/git in the same way?


# Autoload util functions
autoload $OMF_PATH/lib $OMF_PATH/lib/git
autoload $OMF_PATH/lib/git

for path in {$OMF_PATH,$OMF_CONFIG}/pkg/*
set -l name (basename $path)
Expand Down