Refactor installer to support offline installs and more control over user data #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagebind
force-pushed
the
installer-refactor
branch
from
53e7057
to
b007f56
Compare
|
|
||
| return (test $major = $OMF_FISH_MIN_VER[1] -a $minor -ge $OMF_FISH_MIN_VER[2]) | ||
| # Add an exit hook to display a message if the installer aborts or errors. |
sagebind
force-pushed
the
installer-refactor
branch
from
188ae12
to
59794bd
Compare
|
What about using |
|
Still missing is the uninstall method compatible with fish 2.3. |
|
When installing to a path using
|
Closed
sagebind
force-pushed
the
installer-refactor
branch
from
59794bd
to
82e659b
Compare
|
@derekstavis Good suggestions. I just pushed an update that includes/fixes all of them! 👍 |
|
|
||
| set -q CI; or exec fish < /dev/tty | ||
| # Start a new OMF-free shell | ||
| exec fish < /dev/tty |
There was a problem hiding this comment.
Shouldn't this cause an issue with Travis?
sagebind
force-pushed
the
installer-refactor
branch
2 times, most recently
from
d025fec
to
0af1a01
Compare
| is_install_dir "$OMF_PATH" | ||
| or abort "No installation detected at $OMF_PATH" | ||
|
|
||
| say "Warning: This will uninstall Oh My Fish and all plugins and themes installed in $OMF_PATH. Your configuration will not be modified. You will need to remove any Oh My Fish startup code from $FISH_CONFIG/config.fish." |
There was a problem hiding this comment.
I think we could add some space between the messages:
Warning: This will uninstall Oh My Fish and all plugins and
themes installed in /Users/derek/.local/share/omf.
Your configuration will not be modified. You will need to remove any
Oh My Fish startup code from /Users/derek/.config/fish/config.fish.
And also use bold in the last paragraph
sagebind
force-pushed
the
installer-refactor
branch
from
0af1a01
to
dee2ae9
Compare
Refactor the installer to be more maintainable and interactive. The installer is now more robust and safe in its operation, and asks interactive questions for choices that the user must resolve. Setting up confuguration is also now changed to take advantage of Fish 2.3 features and does not mess with user's configuration files without permission. - Make installer smarter and use uninstaller in destroy - Better handling and checking for offline installs - `omf destroy` simply uses `install --uninstall` - Final warning message is no longer displayed when user intentionally aborts install - Backups are restored during uninstall - Update the README to detail the new ways to install OMF
sagebind
force-pushed
the
installer-refactor
branch
from
33647ef
to
00b6931
Compare
This was referenced Aug 14, 2016
Closed
This was referenced Aug 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely refactors the installer. The code is more organized and should be more reliable and consistent.
The new installer supports:
config.fishis no longer required for Fish 2.3.0+, usesconf.dinstead