Refactor command execution and help #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagebind
force-pushed
the
feature/portable-help-text
branch
from
f904027
to
ccd2ebc
Compare
- Copy and improve help text, and convert it to AsciiDoc files - Evaluate commands dynamically
sagebind
force-pushed
the
feature/portable-help-text
branch
2 times, most recently
from
133803c
to
f8afc20
Compare
sagebind
force-pushed
the
feature/portable-help-text
branch
from
f8afc20
to
dc21189
Compare
|
Just checkouted the branch. Awesome work!! Looks very beautiful!! I don't know if was intentional, but I see
|
|
@derekstavis Oh boy, that's not supposed to happen! I'll look into the AsciiDoc parser and see if there's a bug. |
|
Darn BSD incompatibilities... that's what I get for not testing on OS X as well as Linux. That visual glitch is fixed now. |
sagebind
added
s:under review
priority: normal
|
It works now!! Getting back to review! |
|
Wow, it works awesomely well. Extra points for the comments in the LGTM |
derekstavis
approved these changes
Jun 29, 2017
|
Sweet; merging into master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why AsciiDoc? It supports definition lists, and Markdown doesn't. The source AsciiDoc formatting also required much less work to transform into something that looks good in the terminal.
If we could handle aliases in some way, we could remove the switch statement altogether and compute the list of available commands by listing the files in
$OMF_PATH/pkg/omf/functions/cli.