Detect themes by fish_prompt instead of name #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Happy to see this restriction going away 👍 |
sagebind
force-pushed
the
fix/better-theme-detection
branch
from
ca2b915
to
32faf74
Compare
|
so much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing a package from outside a repository, we currently need to detect if it is a theme or package. We were doing this by checking for a
theme-prefix, but this enforces repo names on package authors and is too restrictive. Instead, detect a theme by checking for the presence of afish_prompt.fishfile, which should be much more reliable.Fixes #191.