Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR templates and update install.sha256 #709

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

kfkonrad
Copy link
Contributor

Description

This PR adds (and uses) the new pull request template for omf and updates the sha256 checksum for the install script.

It also removes a small quirk from tests/run.fish. The script will run successfully whether or not the apt plugin is installed (it installs apt to test the omf install command), but one of two strange things will happen:

  1. If apt is installed prior to running the test: The warning that apt is already installed will the displayed, this may be confusing.
  2. If apt is not installed prior to running the test: apt will stay on the system after the test has ended.

To fix this we now check whether apt has been installed before testing and if so remove it. This way the test will/should reinstall apt.

The test also handles the second case by removing the apt plugin if it wasn't installed before.

Fixes #687

Environment report

Oh My Fish version:   6
OS type:              Darwin
Fish version:         fish, version 3.0.2
Git version:          git version 2.21.0 Git version:          hub version 2.11.2
Git core.autocrlf:    no
Your shell is ready to swim.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing tests pass locally with my changes
  • I have updated the SHA256 checksum for the install script

@kfkonrad kfkonrad requested a review from a team as a code owner June 13, 2019 19:18
Copy link
Member

@sagebind sagebind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help on this!

@sagebind sagebind merged commit 665452b into oh-my-fish:master Jun 14, 2019
@kfkonrad kfkonrad deleted the issue-687-checksum branch June 25, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer script checksum is out of sync
2 participants