Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing quotation marks in autoloader #711

Merged

Conversation

kfkonrad
Copy link
Contributor

Description

The auto loader lacked quotation marks around a variable. This PR fixes that and with this the bug described in #698. I tested it under both fish 2.7 and 3.0, that's also the reason why I'm attaching two environment reports.

Fixes #698

Environment report for fish 2.7

Oh My Fish version:   6
OS type:              Linux
Fish version:         fish, version 2.7.1
Git version:          git version 2.11.0
Git core.autocrlf:    no
Your shell is ready to swim.

Environment report for fish 3.0

Oh My Fish version:   6
OS type:              Darwin
Fish version:         fish, version 3.0.2
Git version:          git version 2.21.0 Git version:          hub version 2.11.2
Git core.autocrlf:    no
Your shell is ready to swim.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing tests pass locally with my changes

@kfkonrad kfkonrad requested a review from a team as a code owner June 25, 2019 15:18
@derekstavis
Copy link
Member

Confirmed this is an issue and this fixes it.

@derekstavis derekstavis merged commit ee1921b into oh-my-fish:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme installation error
2 participants