Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require bundle package after install #863

Merged
merged 7 commits into from
Mar 9, 2022
Merged

Conversation

Detailer
Copy link
Contributor

Description

After a package dependency was installed from the bundle file, the dependency package was not available for use by the plugin to be installed,. Thus, causing issues with plugins which relied on dependency packages during installation. Added require to packages installed from bundle file as dependencies.

Fixes Related Issue: oh-my-fish/plugin-weather#38

Environment report

Oh My Fish version:   7-35-g3c0c810
OS type:              Linux
Fish version:         fish, version 3.3.1
Git version:          git version 2.32.0
Git core.autocrlf:    no
Checking for a sane environment...
Your shell is ready to swim.

Checklist:

  • [*] My code follows the style guidelines of this project
  • [*] I have performed a self-review of my own code
  • [*] I have commented my code, particularly in hard-to-understand areas
  • [*] I have made corresponding changes to the documentation
  • [*] New and existing tests pass locally with my changes

@Detailer Detailer requested a review from a team as a code owner October 19, 2021 17:07
@scorphus scorphus added the Hacktoberfest Start here for Hacktoberfest! label Oct 19, 2021
scorphus
scorphus previously approved these changes Oct 19, 2021
Copy link
Member

@scorphus scorphus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing and fixing that issue, @Detailer!

@scorphus scorphus dismissed their stale review October 19, 2021 20:43

My bad I didn't see an issue in the PR

@scorphus
Copy link
Member

We're getting there, @Detailer! Sorry for the imprecise directions. I should have experimented that notatin without intermediate the or's.

Copy link
Member

@scorphus scorphus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting there. Please consider my observations and comment on them.

pkg/omf/functions/bundle/omf.bundle.install.fish Outdated Show resolved Hide resolved
pkg/omf/functions/bundle/omf.bundle.install.fish Outdated Show resolved Hide resolved
@scorphus scorphus added hacktoberfest-accepted and removed Hacktoberfest Start here for Hacktoberfest! labels Oct 31, 2021
@scorphus
Copy link
Member

scorphus commented Nov 1, 2021

As I updated the build environments, if you rebase on top of current master, the build should stop failing.

@Detailer
Copy link
Contributor Author

Detailer commented Nov 7, 2021

@scorphus Made code block more readable, added error message in case require $pacakge fails.

@Detailer
Copy link
Contributor Author

Detailer commented Nov 7, 2021

My bad, the error flow was not proper in the last commit. Fixed now.

Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
@scorphus scorphus merged commit b27b3b5 into oh-my-fish:master Mar 9, 2022
@scorphus
Copy link
Member

scorphus commented Mar 9, 2022

Thanks for your contribution, @Detailer! Sorry for the delay.

Thanks for the nudge, @derekstavis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants