-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require bundle package after install #863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing and fixing that issue, @Detailer!
We're getting there, @Detailer! Sorry for the imprecise directions. I should have experimented that notatin without intermediate the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting there. Please consider my observations and comment on them.
As I updated the build environments, if you rebase on top of current master, the build should stop failing. |
@scorphus Made code block more readable, added error message in case |
My bad, the error flow was not proper in the last commit. Fixed now. |
Co-authored-by: Pablo Aguiar <scorphus@gmail.com>
Thanks for your contribution, @Detailer! Sorry for the delay. Thanks for the nudge, @derekstavis. |
Description
After a package dependency was installed from the bundle file, the dependency package was not available for use by the plugin to be installed,. Thus, causing issues with plugins which relied on dependency packages during installation. Added require to packages installed from bundle file as dependencies.
Fixes Related Issue: oh-my-fish/plugin-weather#38
Environment report
Checklist: