Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why use "subject_id" to refer to a concept_id in OHDSI-SQL? #740

Open
ablack3 opened this issue Sep 6, 2023 · 2 comments
Open

Comments

@ablack3
Copy link
Contributor

ablack3 commented Sep 6, 2023

I noticed that we use subject_id to refer to measurement concept id in this query but subject_id is also used to refer to person_id in cohort tables. It seems a bit confusing to me to use "subject_id" in these two different ways.

m.measurement_concept_id AS subject_id,

@ablack3
Copy link
Contributor Author

ablack3 commented Feb 5, 2024

Closing this due to no response or activity after 5 months.

@ablack3 ablack3 closed this as completed Feb 5, 2024
@fdefalco fdefalco reopened this Feb 5, 2024
@fdefalco
Copy link
Contributor

fdefalco commented Feb 5, 2024

This looks like a typo. As to why there is a subject_id column in the cohort table, that is based on a very old decision that the cohort table could potentially be used to derive and store cohorts of different types, for example provider_id or person_id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants