enhanced mimic

README.md

@@ -32,6 +32,14 @@ A fast JSON parser and Object marshaller as a Ruby gem.
 
 ## <a name="release">Release Notes</a>
 
+### Release 2.0.12
+
+ - Another fix for mimic.
+
+ - mimic_JSON now can now be called after loading the json gem. This will
+   replace the json gem methods after loading. This may be more compatible in
+   many cases.
+
 ### Release 2.0.11
 
  - Fixed mimic issue with Debian

ext/oj/oj.c

@@ -979,15 +979,25 @@ define_mimic_json(int argc, VALUE *argv, VALUE self) {
     if (Qnil == mimic) {
 	VALUE	ext;
 	VALUE	dummy;
-
+
+	// Either set the paths to indicate JSON has been loaded or replaces the
+	// methods if it has been loaded.
 	if (rb_const_defined_at(rb_cObject, rb_intern("JSON"))) {
-	    rb_raise(rb_const_get_at(Oj, rb_intern("MimicError")),
-		     "JSON module already exists. Can not mimic. Do not require 'json' before calling mimic_JSON.");
+	    mimic = rb_const_get_at(rb_cObject, rb_intern("JSON"));
+	} else {
+	    mimic = rb_define_module("JSON");
+	}
+	if (rb_const_defined_at(mimic, rb_intern("Ext"))) {
+	    ext = rb_const_get_at(mimic, rb_intern("Ext"));
+	} else {
+	    ext = rb_define_module_under(mimic, "Ext");
+	}
+	if (!rb_const_defined_at(ext, rb_intern("Parser"))) {
+	    dummy = rb_define_class_under(ext, "Parser", rb_cObject);
+	}
+	if (!rb_const_defined_at(ext, rb_intern("Generator"))) {
+	    dummy = rb_define_class_under(ext, "Generator", rb_cObject);
 	}
-	mimic = rb_define_module("JSON");
-	ext = rb_define_module_under(mimic, "Ext");
-	dummy = rb_define_class_under(ext, "Parser", rb_cObject);
-	dummy = rb_define_class_under(ext, "Generator", rb_cObject);
 	// convince Ruby that the json gem has already been loaded
 	dummy = rb_gv_get("$LOADED_FEATURES");
 	if (rb_type(dummy) == T_ARRAY) {
@@ -1001,7 +1011,8 @@ define_mimic_json(int argc, VALUE *argv, VALUE self) {
 		rb_funcall2(Oj, rb_intern("mimic_loaded"), 0, 0);
 	    }
 	}
-
+	dummy = rb_gv_get("$VERBOSE");
+	rb_gv_set("$VERBOSE", Qfalse);
 	rb_define_module_function(mimic, "parser=", no_op1, 1);
 	rb_define_module_function(mimic, "generator=", no_op1, 1);
 	rb_define_module_function(mimic, "create_id=", mimic_create_id, 1);
@@ -1022,6 +1033,7 @@ define_mimic_json(int argc, VALUE *argv, VALUE self) {
 
 	rb_define_module_function(mimic, "parse", mimic_parse, -1);
 	rb_define_module_function(mimic, "parse!", mimic_parse, -1);
+	rb_gv_set("$VERBOSE", dummy);
 
 	array_nl_sym = ID2SYM(rb_intern("array_nl"));			rb_gc_register_address(&array_nl_sym);
 	create_additions_sym = ID2SYM(rb_intern("create_additions"));	rb_gc_register_address(&create_additions_sym);

lib/oj/mimic.rb

@@ -4,15 +4,15 @@ module Oj
   def self.mimic_loaded(mimic_paths=[])
     gems_dir = File.dirname(File.dirname(File.dirname(File.dirname(__FILE__))))
     Dir.foreach(gems_dir) do |gem|
-      next unless (gem.start_with?('json-') || gem.start_with?('json_pure'))
+      next unless (gem.start_with?('json') || gem.start_with?('json_pure'))
       $LOADED_FEATURES << File.join(gems_dir, gem, 'lib', 'json.rb')
     end
     # and another approach in case the first did not get all
     $LOAD_PATH.each do |d|
       next unless File.exist?(d)
-      Dir.entries(d) do |file|
-        next unless file.ends_with?('jsob.rb')
-        $LOADED_FEATURES << file unless $LOADED_FEATURES.include?(file)
+      Dir.foreach(d) do |file|
+        next unless file.end_with?('json.rb')
+        $LOADED_FEATURES << File.join(d, file) unless $LOADED_FEATURES.include?(file)
       end
     end
     mimic_paths.each { |p| $LOADED_FEATURES << p }

lib/oj/version.rb

@@ -1,5 +1,5 @@
 
 module Oj
   # Current version of the module. 
-  VERSION = '2.0.11'
+  VERSION = '2.0.12'
 end

notes

@@ -3,6 +3,20 @@
 ^c^d hide subtree
 ^c^s show subtree
 
+- make test for mimic
+ - try define or load module
+ - see if it works after loading json
+
+- replace_JSON
+ - after json require
+
+- allow maps to be used for classnames when encoding and decoding objects
+ - build a string to string map/table that allows lookups in either direction
+ - could use exising cache to do the mapping for decode
+  - problem if no class_cache
+
+- try hash for cache/str-str mapping
+ - 
 
 ---------------------------
 Tried a separate thread for the parser and the results were poor. The parsing is 10% to 15% of the total so splitting

test/test_mimic_after.rb

@@ -0,0 +1,35 @@
+#!/usr/bin/env ruby
+# encoding: UTF-8
+
+# Ubuntu does not accept arguments to ruby when called using env. To get warnings to show up the -w options is
+# required. That can be set in the RUBYOPT environment variable.
+# export RUBYOPT=-w
+
+$VERBOSE = true
+
+$: << File.join(File.dirname(__FILE__), "../lib")
+$: << File.join(File.dirname(__FILE__), "../ext")
+
+require 'test/unit'
+require 'stringio'
+require 'oj'
+require 'json'
+
+class MimicAfter < ::Test::Unit::TestCase
+
+  def test0_mimic_json
+    assert(!defined?(JSON).nil?)
+    Oj.mimic_JSON
+  end
+
+# dump
+  def test_dump_string
+    Oj.default_options= {:indent => 2} # JSON this will not change anything
+    json = JSON.dump([1, true, nil])
+    assert_equal(%{[
+  1,
+  true,
+  null]}, json)
+  end
+
+end # MimicAfter