Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image for README.md #364

Closed
ohler55 opened this issue Apr 22, 2017 · 21 comments
Closed

Image for README.md #364

ohler55 opened this issue Apr 22, 2017 · 21 comments

Comments

@ohler55
Copy link
Owner

ohler55 commented Apr 22, 2017

Oj needs your help. It wants the README.md page to have a pretty picture to represent the Oj gem. I put one on the page for now but other ideas and someone with artistic skills is sorely needed. Please post your candidate picture in this issue and feel free to vote or comment on the ones you like or don't like.

Here are my poor attempts after following some of @stereobooster ideas. @stereobooster, please post your ideas here too.

oj_hel_fire
oj_times_fire
oj_shade

@ohler55 ohler55 changed the title Image Image for README.md Apr 22, 2017
@stereobooster
Copy link
Contributor

stereobooster commented Apr 22, 2017

meteor

@ohler55
Copy link
Owner Author

ohler55 commented Apr 22, 2017 via email

@stereobooster
Copy link
Contributor

stereobooster commented Apr 22, 2017

path4196

@ohler55
Copy link
Owner Author

ohler55 commented Apr 23, 2017

That would look right at home on a jacket or hat.

@TrevorHinesley
Copy link

TrevorHinesley commented Apr 25, 2017

Top-left comet (with brackets) has my vote!

@ohler55
Copy link
Owner Author

ohler55 commented Apr 28, 2017

Going with the comet theme like the upper let here are a few variations. Not in color yet.

comet
comet_j

@ohler55
Copy link
Owner Author

ohler55 commented May 2, 2017

So @TrevorHinesley and @stereobooster , its time to decide since you are the only two that took an interest. For me, the comet look is pretty decent. I'd like to have the j in there but could be convinced otherwise. What are you thoughts about the last set of variations assuming they will be colored when on the page.

@ahacking
Copy link

ahacking commented May 2, 2017

I actually preferred your first attempt with the flames. Conveyed fast json and Oj quite well.

The comet variations just don't appeal to me but if you are leaning towards those I would avoid the downward ditection.

@ohler55
Copy link
Owner Author

ohler55 commented May 2, 2017

My feelings are the same on the downward direction. I like the flames as well. It was @stereobooster who came up with the idea.

@ahacking
Copy link

ahacking commented May 2, 2017

I thought using the curly braces was a nice touch for the 'big Oh' and that was kind of lost on the commet variants.

The coloured flames on your original logo possibly don't translate so well for a monochrome logo, maybe that could be changed to make the flames a distinct outline. I'd like to see a monochrome version.

@ohler55
Copy link
Owner Author

ohler55 commented May 2, 2017

If the flame is the one I go with I'll work on a monochrome version but really most uses so far are fine with color. For now anyway.

@TrevorHinesley
Copy link

Taking in all commented suggestions, the second comet (upward with brackets), the fifth (downward but keeps the j), or the final one (upward with j) are my vote.

No disrespect intended (we all have opinions and different tastes), but the flames look a bit outdated and less elegant than the comet.

Just my $.02! Thanks for an awesome library.

@ohler55
Copy link
Owner Author

ohler55 commented May 2, 2017

Out of the comets I like the lower one. No disrespect take. Its good to get everyones take on them.

@ohler55
Copy link
Owner Author

ohler55 commented May 3, 2017

Ok, I pushed a new release with a comet logo. http://www.ohler.com/oj. I think I agree with @TrevorHinesley , it does look more modern. The decision isn't final but close I think.

@ohler55 ohler55 closed this as completed May 4, 2017
@stereobooster
Copy link
Contributor

stereobooster commented May 4, 2017

You need to use 2 times more resolution, on retina it looks blurry

UPD: I mean image in README.md

@ohler55
Copy link
Owner Author

ohler55 commented May 4, 2017

ok, will put the higher res image in place and scale it in the image element.

@stereobooster
Copy link
Contributor

screen shot 2017-05-04 at 23 48 52

@ohler55
Copy link
Owner Author

ohler55 commented May 4, 2017

I see what you mean. Tonight for sure. Still doing my regular job. :-)

@ohler55
Copy link
Owner Author

ohler55 commented May 4, 2017

Changed the logo to SVG. It was the only way to get yardoc and also GitHub to be happy and it scales as vectors should scale.

@TrevorHinesley
Copy link

Woooo looks great!!

@ohler55
Copy link
Owner Author

ohler55 commented May 4, 2017

SVG is going to be my go-to format from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants