Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor badge #377

Merged
merged 1 commit into from Jul 23, 2017
Merged

Appveyor badge #377

merged 1 commit into from Jul 23, 2017

Conversation

stereobooster
Copy link
Contributor

No description provided.

@ohler55
Copy link
Owner

ohler55 commented May 6, 2017

I think it is best to get the appveyor worked out before putting the badge up. Given the segfaults are occurring on a simple ruby call I'm not convinced the environment is set up yet. Lets keep this in reserve until the appveyor stuff is dealt with.

@ashmaroli
Copy link
Contributor

Hi, I tried running the tests on my local Windows machine (Windows 7, Ruby 2.3.1) and the tests segfaults occur at places that involve streams (:load_file, etc), :time_format => :unix_zone, and fork()

@ohler55
Copy link
Owner

ohler55 commented Jul 18, 2017

Have you tested with any other Windows versions?

@ashmaroli
Copy link
Contributor

sorry, no.. Just this one..
But Oj works great on it however..

@ohler55
Copy link
Owner

ohler55 commented Jul 18, 2017

Maybe the trick is to exclude tests on Windows and note the limitations.

@ashmaroli
Copy link
Contributor

Maybe the trick is to exclude tests on Windows

As long as they're not testing a fundamental implementation, then it sounds like a plan. Though, it would require guards to ensure things working now don't break in future.

@ohler55
Copy link
Owner

ohler55 commented Jul 18, 2017

If you know which tests fail that would help me get a head start on the exclusions.

@ashmaroli
Copy link
Contributor

I was able to bypass segfaults by skip-ping test_file.rb#dump_and_load, test_object.rb#test_time_early

@ohler55
Copy link
Owner

ohler55 commented Jul 21, 2017

Thanks.

@ohler55
Copy link
Owner

ohler55 commented Jul 23, 2017

Working through the tests. The early time is fixed, sort of. Windows does not support dates before 1970 so that test will never pass on Windows. Same with fork. Anyway, working now so will merge this PR.

@ohler55 ohler55 merged commit 8da0354 into ohler55:master Jul 23, 2017
@ohler55
Copy link
Owner

ohler55 commented Jul 23, 2017

Finally got appveyer working so now it makes sense to put up the badge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants