Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages for invalid escape sequences #21

Open
pdubroy opened this issue Jun 3, 2015 · 2 comments
Open

Improve error messages for invalid escape sequences #21

pdubroy opened this issue Jun 3, 2015 · 2 comments

Comments

@pdubroy
Copy link
Contributor

pdubroy commented Jun 3, 2015

Rather than a generic parse error, we should have a message like "Invalid escape sequence: \p"
@pdubroy
Copy link
Contributor Author

pdubroy commented Jun 3, 2015

Fixed by 56d8ff5.

@pdubroy pdubroy closed this as completed Jun 3, 2015
@pdubroy pdubroy reopened this Jun 6, 2015
@pdubroy
Copy link
Contributor Author

pdubroy commented Jun 6, 2015

Fix was reverted (21ca368) because it wasn't right -- grammars should not be accepting invalid inputs. Alex modified the grammar so that the generic parse failure is more useful for this cause, we could still make the errors a lot clearer.

@pdubroy pdubroy added the uw label Oct 24, 2016
njjewers added a commit to njjewers/ohm that referenced this issue Nov 13, 2016
@njjewers
Experimental fix for ohmjs#21
6b46617
@njjewers njjewers mentioned this issue Nov 13, 2016
Open
@pdubroy pdubroy removed the uw label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pdubroy