Remove grammar, _value, toJSON() from nodes #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m nodes - grammar only needs to be on the root node - ctorName becomes a getter defined in the nodes classes - _value on TerminalNodes was already deprecated — this removes it totally - remove toJSON as it was only used for experimental features in the Ohm Editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grammaronly needs to be on the root node. Removing it from the other nodes saves memory.ctorNamebecomes a getter defined in the nodes classes, rather than a per-instance property.primitiveValueproperty of wrappers was already deprecated; this PR removes it entirely. The_valueproperty of TerminalNodes is also removed.toJSON()method on nodes, which was only used for experimental features in theOhm Editor.