Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotation for bottom parts #669

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

ohmtech-rdi
Copy link
Owner

This PR fixes the rotation of bottom parts in the generated centroid.

Caution

This is a breaking change. All PCBA made with ERB needs to fix their rotation when using bottom parts, for parts for which orientation is critical. This won't affect resistors or non-polarised capacitors.

  • Centroid doesn't make a difference for rotation between top and bottom. In Kicad, the footprint is just flipped, so seen from one face, the footprint will align with the same rotation. This means that footprints must be rotated 180° when on the bottom face,
  • Centroid doesn't make a difference for rotation between top and bottom. In Kicad, front part rotation is CCW but bottom part rotation is CW. This means we need to rotate the other way on the bottom,
  • Reel rotation is irrelevant of top or bottom, so we need to compensate for all those applied rotation for it.

We tested this with 3 parts:

  • A diode that is OK with 0 reel rotation
  • A cap with 180 reel rotation
  • A TL074 with 90 reel rotation

We did a test file with all 4 rotations on each side, then compared.

image

image

(the misaligned pads seem to be a weird bug in JLCPCB preview for some reason. The gerbers were fine, and we were only considering the centroid anyway)

@ohmtech-rdi ohmtech-rdi added the bug Something isn't working label Feb 28, 2024
@ohmtech-rdi ohmtech-rdi self-assigned this Feb 28, 2024
@ohmtech-rdi ohmtech-rdi merged commit 733a771 into main Feb 28, 2024
21 checks passed
@ohmtech-rdi ohmtech-rdi deleted the erbui-centroid-fix-bottom-rotation-again branch February 28, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant