Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap and swapoff #49

Merged
merged 3 commits into from
Sep 20, 2016
Merged

swap and swapoff #49

merged 3 commits into from
Sep 20, 2016

Conversation

piranna
Copy link
Contributor

@piranna piranna commented Sep 9, 2016

This fixes #46.

@piranna piranna mentioned this pull request Sep 9, 2016
@melor
Copy link
Member

melor commented Sep 15, 2016

This looks otherwise ok, but will fail to compile on non-Linux platforms, which I warned about in #46 (comment) The code needs to use the proper preprocessor directives (#ifdef/#ifndef) to allow compilation on any posix OS.

Also, can you please add a documentation section in README.md?

@piranna
Copy link
Contributor Author

piranna commented Sep 15, 2016

I've just updated the pull-request with your suggestions :-)

2016-09-15 23:42 GMT+02:00 Mika Eloranta notifications@github.com:

This looks otherwise ok, but will fail to compile on non-Linux platforms,
which I warned about in #46 (comment)
#46 (comment) The
code needs to use the proper preprocessor directives (#ifdef/#ifndef) to
allow compilation on any posix OS.

Also, can you please add a documentation section in README.md?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#49 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgfvimOWaSXOYqeIH6FedCSkI1ySf_kks5qqbvFgaJpZM4J5fCK
.

"Si quieres viajar alrededor del mundo y ser invitado a hablar en un monton
de sitios diferentes, simplemente escribe un sistema operativo Unix."
– Linus Tordvals, creador del sistema operativo Linux

melor added a commit that referenced this pull request Sep 20, 2016
@melor melor merged commit 2b6784a into ohmu:master Sep 20, 2016
@melor
Copy link
Member

melor commented Sep 20, 2016

Thanks! Fixed a minor issue with older node versions and now this is published as posix@4.1.0

@piranna
Copy link
Contributor Author

piranna commented Sep 20, 2016

Cool, thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swapon
2 participants