"_command_exists" used in battery plugin but is not defined anywhere!

[antofthy]

TLDR: command_exists() is defined in

oh-my-bash/lib/base.sh

Line 267 in 429ffc1

command_exists () {

, but it's not used in https://github.com/ohmybash/oh-my-bash/blob/master/plugins/battery/battery.plugin.sh which expects _command_exists() where _ prefix is important.

Summarized by @Kreyren

---

Title basically says it all...

A function "_command_exists" is used in the battery plugin, but is not defined anywhere else in the repository.

... removed personal "cmd_found" equivalent function, designed for older shells ...

[antofthy]

ASIDE: I also recommend breaking the percentage bar graph out to a separate utility.
Though it is an interesting (colorful) 5 character output.

I have found ahaving a script to generate a bar graph from a percentage is a very useful thing to have.
Example (could be more colorful)...
http://www.ict.griffith.edu.au/anthony/software/percent.sh.txt

[Kreyren]

Assigned P2 as bug.

Investigation needed -> Currently fix unknown.

[Kreyren]

@antofthy _command_exists where? (repository is using 3rd party code for completetion etc..)

[Kreyren]

Lowering priority untill info is provided

[antofthy]

More information... Okay...

The plug-in "plugins/battery/battery.plugin.sh" used a function _command_exists multiple times (over a dozen). And yet a search of the whole repository did not turn up that function anywhere else, except its use in that plugin. It is simply not defined anywhere.

On the other hand in "lib/base.sh" a function "command_exists()" is defined!

command_exists () {
  type "$1" &> /dev/null ;
}

And in "lib/utils.sh" a simular function "type_exists()" is also defined...

type_exists() {
  if [ "$(type -P "$1")" ]; then
    return 0
  fi
  return 1
}

Which could be rewritten more concisely as...

type_exists() {
  [ "$(type -P "$1")" ]
}

Though checks if the given argument is an external command, and ignores functions of the same name. But its is used for same purpose.

In summery. The plug-in is broken. And in looking for a fix I found the two different functions being used for the same purpose. One probably should replace the other.

[Kreyren]

type_exists() was referenced in #103

contributions are welcomed since i'm trying to improve the code quality pasively (since it needs rewriting of lots of things)

EDIT: Note #73

---

About the command_exists() and _command_exists() it's stupid, but it doesn't create conflicts since they are different.

Edit: To clarify oh-my-bash should be able to source lib/base.sh for this

ping @nntoan How do you want to resolve conflicts alike?

[Kreyren]

@antofthy Referencing #104 if only command_exists() is the issue this should fix it.