VS CODE terminal cannot start, after udpate oh-my-zsh #12331
Comments
|
You can avoid the problem temporarily. cd ~/.oh-my-zsh
git checkout 6dfa9507ce0eb0f4d386bd03268e33943ea55c0fand then, try again. |
|
Hi! I can't reproduce any issue. What's exactly happening? Could you share a screen recording or further describe the issue? @taekinkim does it happen to you as well? |
|
@carlosala I have worked in vscode with remote-ssh connection. The server is like: |
|
I have tried with several omz commits. |
|
@CherryYang05 reported in #12344:
|
|
Can you reproduce the issue with tracing enabled (running zsh as |
mcornella
added
Bug
|
@mcornella The last part of results of (and then segmentation fault occured.) If I change the code: Line 41 in 53c4c46 into: diff --git a/lib/git.zsh b/lib/git.zsh
index c426597..9d19b0d 100644
--- a/lib/git.zsh
+++ b/lib/git.zsh
@@ -38,7 +38,7 @@ function _omz_git_prompt_info() {
}
# Enable async prompt by default unless the setting is at false / no
-if zstyle -T ':omz:alpha:lib:git' async-prompt; then
+if zstyle -t ':omz:alpha:lib:git' async-prompt; then
function git_prompt_info() {
setopt localoptions noksharrays
if [[ -n "$_OMZ_ASYNC_OUTPUT[_omz_git_prompt_info]" ]]; thenzsh is executed without any problem. |
|
Could you try in master branch, but doing |
|
@carlosala |
|
So, in that moment ( |
|
Yes, it is right. |
|
Could you try in master but reverting that commit? I'm certain it should to be that one. |
|
I'll try to bisect. Which OS and version reproduces the issue? EDIT: I see that centos 7 reproduces it👍🏻 |
|
@taekinkim is it reproducible as well if you just |
|
I also used docker container. I did ssh-connect to the container in vscode. Here is the segmentation fault in server connected directly: |
|
I'm still not able to do so. Not sure what's missing. Could you send a screenshot after executing |
|
my theme: when i add this line "PROMPT+=' $(git_prompt_info)'" , it happens |
|
+1 I have reproduce the same issue: ec1afe9 commit: |
Could anyone send this? |
The branch I am currently on is 31f2025, and enclosed is a screenshot taken prior to the termination of zsh. 
|
|
Hi folks, thanks for all the reports and logs and such. Unfortunately we are unable to reproduce the issue (i.e. get it to core-dump). We have tested using CentOS 7 containers, as well as with a VM. However, based on #12331 (comment) we see that the segfault happens at the Checking the blame for zsh, we found that a segfault was fixed on zsh 5.0.6 (commit and related zsh-workers thread). We were able to see that 5.0.6 was the first version to also not be affected by the stale branch info reported. We therefore believe that 5.0.6 will not have the issue. I have also a hunch that If we are unable to find the root cause, and as we can't successfully reproduce it, we will then disable the feature for zsh < 5.0.6, and just recommend that people upgrade (we know this is sometimes not a possibility, therefore we'll just turn off the async feature by default). |
$ cat /etc/centos-release
CentOS Linux release 7.6 (Final)
zsh --version
zsh 5.0.2 (x86_64-redhat-linux-gnu)
ZSH_THEME="random"
...
plugins=(git zsh-syntax-highlighting)
...
The above is the environment in which I have problems, i use random theme, and I have installed zsh-syntax-highlighting plugin. The following kinds of scenarios are ok:
Hope this info helps!!! |
As the test above concludes, I rollback the ec1afe9 commit and the problem disappeared, so if you guys have already determined that it's a historical bug in zsh, would it be possible to add a versioning judgment instead of forcing people to upgrade their zsh version
|
That confirms our suspicions that 5.0.6 fixes the issue (in commit zsh-users/zsh@97115e0).
Yes, that was what I said in #12331 (comment). The reason ec1afe9 keeps coming up in your tests of the bug introduction has already been explained: that's the one where we enable git async prompt by default. We already suggested the mitigation of disabling the setting, but I realise not in this specific thread: https://github.com/ohmyzsh/ohmyzsh#disable-async-git-prompt. Now, as we can't reproduce the issue, we are trying to verify whether In the meantime, I have already pushed the code (1ed8d4b) that disables async prompt for 5.0.5 and older. You can get it with Please confirm whether #12358 fixes this. We need your test on this, otherwise you'll miss out on the feature. |
I need test from vscode and random themes, and i don't know |
Describe the bug
when i update oh-my-zsh, i cannot start a terminal window in vscode
Steps to reproduce
1.update oh-my-zsh,
2. i cannot start a terminal window in vscode
Expected behavior
how can i fix it
Screenshots and recordings
No response
OS / Linux distribution
linux
Zsh version
zsh 5.0.2 (x86_64-redhat-linux-gnu)
Terminal emulator
vscode
If using WSL on Windows, which version of WSL
None
Additional context
No response
The text was updated successfully, but these errors were encountered: