Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(init): add options to disable Oh My Zsh aliases #10510

Closed

Conversation

gabrielcosta42
Copy link

Closes #9414, resolves #8344, closes #7328, closes #6630, resolves #8933, resolves #8015, closes #9621

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.

Changes:

  • Added option to not enable any alias from Oh My Zsh: DISABLE_OMZ_ALIASES
  • Added option to not enable Oh My Zsh plugins aliases: DISABLE_OMZ_PLUGIN_ALIASES

Other comments:

Long time requested feature.
...

@mcornella
Copy link
Member

Hi @gabrielcosta42, thanks for the Pull Request and getting all the issues at the same time. I don't love the solution though. There's a proposal for a way to turn off aliases in #10644. Please have a look and add your feedback. Thanks!

@gabrielcosta42
Copy link
Author

@mcornella zstyles seems to be the way to go, I`m not familiar with it though, it will take some time to learn.

@carlosala
Copy link
Member

Yes, zstyle is absolutely the way of customizing things in ZSH nowadays. Adapting OMZ to it seems the most rational thing to do

@azinsharaf
Copy link

azinsharaf commented Mar 5, 2023

Is this PR still in review?

@carlosala
Copy link
Member

We'll be implementing in the future a better approach to it. Closing this to avoid confusion.
Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment