Add configuration placeholders to installer template #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've rebased this to your master again, let me know if you still want to merge it. |
|
@avit can you rebase again? |
|
Wow it's been a while! Sure, I will. |
|
@avit any luck there? :-) |
Although the zshrc template adds a PATH= string, this is overwritten by the installer script. This allows it to be placed anywhere in the file instead of having to append at the end.
|
@robbyrussell get it while it's hot. |
robbyrussell
added a commit
that referenced
this pull request
Dec 3, 2013
Add configuration placeholders to installer template
hughdbrown
pushed a commit
to hughdbrown/oh-my-zsh
that referenced
this pull request
Dec 6, 2013
Add configuration placeholders to installer template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installer script should say where to go and what to do with the installed configuration.
I added some commented lines in the zshrc template to show what kind of customization belongs in there. (PATH, EDITOR, etc.)