Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update last updated time if there are no available updates #11056

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jnooree
Copy link

@jnooree jnooree commented Jul 19, 2022

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.

Changes:

  • Call update_last_updated_file if there are no available updates.

Other comments:

The :omz:update frequency configuration does not have to be exact "update" days; it is sufficient to check every frequency day.

This change is proposed because the is_update_available function accesses the network, so it consumes a significant amount of time on every startup until there are some upstream updates.

The ":omz:update frequency" configuration does not have to be exact "update" days;
it is sufficient to check every "frequency" day.
@ohmyzsh ohmyzsh bot added Area: core Issue or PR related to core parts of the project Area: updater Update subsystem labels Jul 19, 2022
@jnooree jnooree changed the title Update last updated time if no available updates Update last updated time if there are no available updates Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: core Issue or PR related to core parts of the project Area: updater Update subsystem
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

None yet

1 participant