Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins/term_tab): MacOS support for completion of zsh sessions working directory #11060

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Simske
Copy link

@Simske Simske commented Jul 21, 2022

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.

Changes:

  • Extended term_tab plugin to work on Mac
  • Updated Readme of plugin term_tab

Other comments:

The term_tab plugin only Linux and Solaris hosts, as the logic is OS specific.
This adds the same functionality for MacOS.

Tested on MacOS 12.2.1 ARM, zsh 5.8 (x86_64-apple-darwin21.0)

@ohmyzsh ohmyzsh bot added the Area: plugin Issue or PR related to a plugin label Jul 21, 2022
@Simske Simske marked this pull request as ready for review July 22, 2022 12:01
The term_tab plugin only Linux and Solaris hosts, as the logic is OS specific.
This adds the same functionality for MacOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: plugin Issue or PR related to a plugin
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

None yet

2 participants